.Values vs .Environment.Values

[eddycharly]

Hi,
I'm new to helmfile and am playing with it.
I am not sure when i should use .Environment.Values, as using .Values seems to be working.

For example :

{{ if .Values.core.metricsServer.enabled }}
  - name: metrics-server
    namespace: core
    chart: stable/metrics-server
    values:
      - templates/core/metrics-server.yaml
{{ end }}

In the example above .Values.core.metricsServer.enabled is correctly set to true/false.

Should i use .Environment.Values.core.metricsServer.enabled instead ?
Or .Values.core.metricsServer.enabled is fine ?

[mumoshu]

@eddycharly .Values is added via #647 which is expected to be an experimental feature that replaces current .Environment.Values :)

Please try it and report back if it works or not, so that I can move forward.

[eddycharly]

Thanks @mumoshu.
I’ll stick with .Values and let you know if it doesn’t work.

[eddycharly]

Hi @mumoshu,
I was about to close the issue as it works perfectly but i saw you wanted help.
How can i help you ? Do you want me to update the documentation part ?

[mumoshu]

@eddycharly Yes! Updating the documentation with recommending the new way while deprecating the old way would be greatly appreciated.

[eddycharly]

@mumoshu just made a PR #839 with documentation update.

[eddycharly]

@mumoshu have you had time to give an eye to the pr ?