Send custom 'end' event #1235
Merged
Send custom 'end' event #1235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shankj3
reviewed
Jul 11, 2025
| 'rrweb-replay-events', | ||
| { | ||
| eventType: 5, | ||
| json: JSON.stringify({tag: "replay.end", payload: {}}), |
There was a problem hiding this comment.
This won't help us in the case of someone closing a tab, right?
Ie previous recording events have already been sent for this replay, then one more is going to be sent in the near future but tab is closed
There was a problem hiding this comment.
This span either gets sent in whole, or not at all. The purpose of adding this event is so that the player extends its playback until the triggering occurrence occurs. (It's almost like giving the occurrence an rrweb event.)
shankj3
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Helps the application correctly align playback by adding a noop event to the end of the recording.
Type of change