Fix browserify example to use modern rollbar package
#1251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the browserify example by replacing the deprecated rollbar-browser package with the current rollbar package and adding proper build tooling. The changes ensure the example works with current package versions and follows better practices for handling generated files.
- Updates dependency from deprecated
rollbar-browserto modernrollbarpackage - Adds proper build script and removes generated bundle from version control
- Simplifies build instructions in documentation
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
examples/browserify/package.json |
Updates dependency to rollbar package and adds build script with browserify devDependency |
examples/browserify/index.js |
Changes require statement to use rollbar instead of rollbar-browser |
examples/browserify/all.js |
Removes generated browserify bundle file from version control |
examples/browserify/README.md |
Updates documentation to reflect new package name and simplified build process |
examples/browserify/.gitignore |
Adds gitignore to exclude generated bundle files |
matux
force-pushed
the
matux/fix-browserify-example
branch
from
17978c1 to
debf730
Compare
waltjones
approved these changes
Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR updates the
browserifyexample from deprecatedrollbar-browserto therollbarpackage. Also added proper build tooling and cleaned up generated filesChanges
Type of change
Related issues
SDK-518/make-sure-all-sdk-examples-work-properly