Skip to content

Conversation

matux
Copy link
Contributor

@matux matux commented Jul 22, 2025

Description of the change

This PR hardcodes the jquery version in the script itself @ src/browser/plugins/jquery.js instead of importing it. Importing was causing the entire hierarchy of defaults file to get embedded in the minified file. The rationale for hardcoding the version is that 1. it was already hardcoded it (where is the version even coming from?), and it's only required at the point of use, which is the script itself.

I've also separated the defaults for the rollbar.snippet.js, although this does the same importing to grab the version, it seems to affect the size positively as it's not embedding anyrthing other than the version string, thus the rollbar.snippet.js is now smaller.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

@matux matux self-assigned this Jul 22, 2025
@matux matux merged commit 6008562 into master Jul 22, 2025
4 checks passed
@matux matux deleted the matux/separate-defaults-for-jquery-and-snippet branch July 22, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants