Separate defaults for snippet and hardcore jquery version #1259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR hardcodes the jquery version in the script itself @
src/browser/plugins/jquery.js
instead of importing it. Importing was causing the entire hierarchy of defaults file to get embedded in the minified file. The rationale for hardcoding the version is that 1. it was already hardcoded it (where is the version even coming from?), and it's only required at the point of use, which is the script itself.I've also separated the defaults for the
rollbar.snippet.js
, although this does the same importing to grab the version, it seems to affect the size positively as it's not embedding anyrthing other than the version string, thus therollbar.snippet.js
is now smaller.Type of change