Add support for active record read_attribute public method #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @JonRowe 👋 , I see the CI |
nourmat
force-pushed
the
add-support-for-read-attribute
branch
2 times, most recently
from
b83fa80 to
d0e04cc
Compare
This comment was marked as resolved.
This comment was marked as resolved.
nourmat
force-pushed
the
add-support-for-read-attribute
branch
from
d0e04cc to
6fcf4d8
Compare
|
yeah, I messed something unintentionally, fixing it now |
nourmat
force-pushed
the
add-support-for-read-attribute
branch
from
6fcf4d8 to
e440d40
Compare
|
I can’t in this repo @JonRowe 😓 |
|
No worries, let's wait for Jon :D |
|
@JonRowe, I just went ahead and fixed the new rubocop errors, made since I guess. |
|
Merged in 32c7de3 |
|
Released in 1.3.0, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
read_attributemethodChanges
alias_method :read_attribute, :[]to support Rails 7.1+read_attributemethodread_attribute,_read_attribute, and[]methodsWhy
Rails 7.1+ introduced
read_attributeas a public method for external usage, similar torecord['id']. This change ensures compatibility with newer Rails versions.It's called in other gems e.g Bullet version 8.0.8 uses this public method here which causes errors in specs like
RSpec::Mocks::MockExpectationError