Skip to content

Conversation

MoumitaM
Copy link
Contributor

@MoumitaM MoumitaM commented May 18, 2022

Description of the change

Our goal is to get notified regarding errors beforehand and take action depending on that before a customer alerted us. In order to achieve that we planned to send handled and unhandled errors from JS SDK using the Bugsnag error reporting tool. So that we can create an alerting system on top of that.

Changes:

  • Loaded Bugsnag's client SDK in our SDK load call.
  • If the feature is enabled then only initialize the SDK.
  • Created a separate module for Bugsnag and exported load and initialize function.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@saikumarrs
Copy link
Member

saikumarrs commented May 18, 2022

@MoumitaM Please update the following before the PR is marked ready for review:

  • PR title.
    • Make it more meaningful.
  • PR description
    • It doesn't provide enough context. It should specifically answer the "why" and "what" questions.
    • Update relevant sections.

@MoumitaM MoumitaM changed the title Feat.crash reporting metrics Crash reporting metrics implementation with Bugsnag May 19, 2022
MoumitaM and others added 3 commits May 19, 2022 11:53
Co-authored-by: Sai Kumar Battinoju <[email protected]>
Co-authored-by: Sai Kumar Battinoju <[email protected]>
Co-authored-by: Sai Kumar Battinoju <[email protected]>
@MoumitaM MoumitaM requested a review from saikumarrs May 20, 2022 04:59
MoumitaM and others added 2 commits May 23, 2022 11:14
Co-authored-by: Sai Kumar Battinoju <[email protected]>
Co-authored-by: Sai Kumar Battinoju <[email protected]>
MoumitaM and others added 2 commits June 11, 2022 17:58
@saikumarrs saikumarrs merged commit 69aea55 into v1-staging Jun 21, 2022
@saikumarrs saikumarrs deleted the feat.crashReportingMetrics branch June 21, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for review Changes are ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants