Skip to content

Conversation

ItsSudip
Copy link
Member

@ItsSudip ItsSudip commented Oct 19, 2022

Description of the change

In GA destination we are only supporting the total. With this change, we are adding support of revenue along with the total for eCommerce events.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@ItsSudip ItsSudip merged commit 88b49b7 into v1-staging Oct 21, 2022
@ItsSudip ItsSudip deleted the fix.ga-am-ecom-fileds branch October 21, 2022 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants