Skip to content

add is_inherited methods to InheritableDependency and InheritableField #15828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2025
Merged

add is_inherited methods to InheritableDependency and InheritableField #15828

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e58ab62
add is_inherited method to InheritableDependency
2ndDerivative Aug 12, 2025
6d3ff14
add is_inherited method to InheritableField
2ndDerivative Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions crates/cargo-util-schemas/src/manifest/mod.rs
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parsing backend for crates-io

I am fine we adding these helper functions. Just curious about the thing you're doing. Mind sharing a bit more?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am experimenting with replacing the toml parsing backend of crates.io with cargo_util_schemas since that's what cargo is using to produce the toml file in cargo package.

It's just an experiment, so I'd like to keep these either way (I also wanna use c_u_s for an own registry I'm implementing)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacing with cargo-util-schemas in the official crates.io project? You might want to look at rust-lang/crates.io#7811, and the other functionalities it is using that cargo-utuil-schemas lacks.

Anyway, thanks for the info. Merging!

Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,10 @@ impl<T> InheritableField<T> {
InheritableField::Value(defined) => Some(defined),
}
}

pub fn is_inherited(&self) -> bool {
matches!(self, Self::Inherit(_))
}
}

//. This already has a `Deserialize` impl from version_trim_whitespace
Expand Down Expand Up @@ -675,6 +679,10 @@ impl InheritableDependency {
InheritableDependency::Inherit(_) => Err(UnresolvedError),
}
}

pub fn is_inherited(&self) -> bool {
matches!(self, InheritableDependency::Inherit(_))
}
}

impl<'de> de::Deserialize<'de> for InheritableDependency {
Expand Down
Loading