Disallow shebang in --cfg and --check-cfg arguments
#146211
Merged
+75
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rustbot
added
A-run-make
fmease
approved these changes
Sep 5, 2025
fmease
added
the
relnotes
|
Okay, so process-wise I'm not quite sure how to proceed. An MCP is overkill and a T-compiler FCP is also slightly overkill. I did add relnotes for formality. I'm inclined to just approve this unilaterally which I've done a few times for minor T-lang breaking changes over the years (notably only ones which were obviously not affecting real users and which were quite clearly bugs) (most recently in RUST-145604). Re. crater, it's not worth testing (esp. because of the high infra costs) and the beta crater runs would be sufficient in covering that. |
|
r=me with nitpicks addressed |
fmease
added
S-waiting-on-author
Urgau
force-pushed
the
cfg-disallow-shebang
branch
from
2983825 to
d224d3a
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@bors r+ |
bors
added
S-waiting-on-bors
Honestly I'd say just do this, shebang was never intended to be supported in |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 6, 2025
Disallow shebang in `--cfg` and `--check-cfg` arguments This PR is similar to rust-lang#146130, where we disallowed frontmatter in `--cfg` and `--check-cfg` arguments. While fixing the other one we also discovered that shebang `#!/usr/bin/shebang` are currently also allowed in `--cfg` and `--check-cfg` arguments. Allowing shebang in them (which are just ignored) was never intended, this PR fixes that by not stripping shebang for `--cfg` and `--check-cfg` arguments. This is technically a breaking-change, although I don't expect anyone to actually rely on this unintended behavior. Fixes rust-lang#146130 (comment) r? fmease
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 6, 2025
Disallow shebang in `--cfg` and `--check-cfg` arguments This PR is similar to rust-lang#146130, where we disallowed frontmatter in `--cfg` and `--check-cfg` arguments. While fixing the other one we also discovered that shebang `#!/usr/bin/shebang` are currently also allowed in `--cfg` and `--check-cfg` arguments. Allowing shebang in them (which are just ignored) was never intended, this PR fixes that by not stripping shebang for `--cfg` and `--check-cfg` arguments. This is technically a breaking-change, although I don't expect anyone to actually rely on this unintended behavior. Fixes rust-lang#146130 (comment) r? fmease
bors
added a commit
that referenced
this pull request
Sep 6, 2025
Rollup of 3 pull requests Successful merges: - #127316 (move pinned version from tracing_core to tracing) - #144801 (Suggest bounds in more cases, accounting for type parameters referenced in predicate) - #146211 (Disallow shebang in `--cfg` and `--check-cfg` arguments) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Sep 6, 2025
Rollup of 5 pull requests Successful merges: - #127316 (move pinned version from tracing_core to tracing) - #144801 (Suggest bounds in more cases, accounting for type parameters referenced in predicate) - #146211 (Disallow shebang in `--cfg` and `--check-cfg` arguments) - #146263 (Fix `bump-stage0` build failure, and check-build `bump-stage0` in CI) - #146266 (miri std tests: skip all of sys::) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Sep 6, 2025
Rollup merge of #146211 - Urgau:cfg-disallow-shebang, r=fmease Disallow shebang in `--cfg` and `--check-cfg` arguments This PR is similar to #146130, where we disallowed frontmatter in `--cfg` and `--check-cfg` arguments. While fixing the other one we also discovered that shebang `#!/usr/bin/shebang` are currently also allowed in `--cfg` and `--check-cfg` arguments. Allowing shebang in them (which are just ignored) was never intended, this PR fixes that by not stripping shebang for `--cfg` and `--check-cfg` arguments. This is technically a breaking-change, although I don't expect anyone to actually rely on this unintended behavior. Fixes #146130 (comment) r? fmease
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is similar to #146130, where we disallowed frontmatter in
--cfgand--check-cfgarguments. While fixing the other one we also discovered that shebang#!/usr/bin/shebangare currently also allowed in--cfgand--check-cfgarguments.Allowing shebang in them (which are just ignored) was never intended, this PR fixes that by not stripping shebang for
--cfgand--check-cfgarguments.This is technically a breaking-change, although I don't expect anyone to actually rely on this unintended behavior.
Fixes #146130 (comment)
r? fmease