DynamicConfig: use canonical clone impl #146240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @SparrowLii rustbot has assigned @SparrowLii. Use |
rustbot
added
A-query-system
|
I tried changing the manual Copy and Clone impls to a derive clause, but that ends up causing lots of unsatisfied trait bounds. I don't understand why that does not work. The single shared reference member should impl Copy, and the automatically derived impls should be identical to the manual impls AFAICT. Apparently I'm wrong about this somehow. Would love to understand! |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
|
Just using a derive will introduce a |
bors
added a commit
that referenced
this pull request
Sep 7, 2025
Rollup of 4 pull requests Successful merges: - #146200 (Simplify rustdoc-gui tester by calling directly browser-ui-test) - #146236 (gpu offload: change suspicious map into filter) - #146240 (DynamicConfig: use canonical clone impl) - #146251 (rustc_middle: clippy fixes) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Sep 7, 2025
Rollup merge of #146240 - hkBst:query-1, r=cjgillot DynamicConfig: use canonical clone impl Fixes clippy warning: ```text warning: non-canonical implementation of `clone` on a `Copy` type --> compiler/rustc_query_impl/src/lib.rs:60:29 | 60 | fn clone(&self) -> Self { | _____________________________^ 61 | | DynamicConfig { dynamic: self.dynamic } 62 | | } | |_____^ help: change this to: `{ *self }` ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes clippy warning: