error: feature-gate ExternalError #271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This type is only used when the `crypto` or `pem` features are enabled, producing a warning with Rust 1.80 clippy when building with `--no-default-features`. This commit config-gates its definition to avoid that warning.
djc
approved these changes
May 3, 2024
|
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nightly updated and there's some new findings of the form "error: unexpected |
In a few places we were using `#[cfg(crypto)]` instead of `#[cfg(feature = "crypto")]`. Latest rust nightly is correctly flagging this as unexpected. This commit fixes those feature gates, and in the process starts running some unit tests that were effectively inert before now. They in turn require some small API tweaks to catch up with the state of `main`.
Done. The reported errors from nightly helped uncovered we had some inert unit tests that also needed fixing. Nice 👍 |
djc
approved these changes
May 6, 2024
|
This still feels non-functional/small enough to merge without blocking for another review. Happy to re-calibrate for next time if I'm jumping the gun. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This trait is only used when the
cryptoorpemfeatures are enabled, producing a warning with Rust 1.80 clippy (as seen in CI failures) when building with--no-default-features. This commit config-gates its definition to avoid that warning.