-
Notifications
You must be signed in to change notification settings - Fork 130
Distribute methods for parsing params elements from x509 #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Thank you.
I think the coverage CI failures are fair to ignore since they're pre-existing coverage gaps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense but can you squash?
Why? All of these commits compile and could likely pass CI on their own. |
I feel it's too fine. I think it should be easy to squash the "Move ..." commits together, they are form an independent unit compared to the other commits. |
What are the downsides of merging smaller commits? If there's ever a regression or you want to sift through |
On the other hand, it's harder to understand the motivation of a bigger commit compared to a small one. But whatever, it's bikeshedding. Let's just merge this one. |
This takes the processing steps for transforming an
x509_parser::Certificate
intoCertificateParams
and distributes them over the relevant element's types, in preparation for splittingfrom_ca_cert_pem()
andfrom_ca_cert_der()
fromCertificateParams
(to make it statically obvious that their use is only intended to build anIssuer
).