Regression: rubies are not installed

[thbar]

I believe #204 introduced a regression which forbids the installation of the configured rubies, at least for me on Ansible 2.8.3.

In this code:

rvm1-ansible/tasks/rubies.yml

Lines 11 to 14 in deb1d3e

	- name: Install rubies
	command: '{{ rvm1_rvm }} install {{ item.item }} {{ rvm1_ruby_install_flags }}'
	when: rvm1_rubies | bool and item.rc|default(0) != 0
	with_items: '{{ detect_rubies.results }}'

the rvm1_rubies | bool expression evaluates to false, which makes the install be skipped:

TASK [rvm.ruby : Install rubies] *************************************************************************
skipping: [vagrant-geo] => (item={'skip_reason': u'Conditional result was False', 'item': u'ruby-2.5.3', 'skipped': True, 'ansible_loop_var': u'item', 'changed': False}) 

This later results in an error during Install bundler if not installed, as reported by @AwolDes here:

#204 (comment)

Because no ruby is installed, the default alias is created, but the link resolves to a non-existing folder.

The explanation is here:

https://medium.com/opsops/wft-bool-filter-in-ansible-e7e2fd7a148f

[1,2,3]|bool -> false

I believe #207 and #208 are proposals to fix this.

[thbar]

FWIW, #204 PR was failing during CI because of this exact problem.

In particular, see:

• installing rubies is skipped at https://travis-ci.org/rvm/rvm1-ansible/builds/557845602#L570
• the error occurs at https://travis-ci.org/rvm/rvm1-ansible/builds/557845602#L590

[thbar]

Reverting to latest Galaxy release (2.1.2) solve the issue.

[froblesmartin]

Same issue here! #207 fixed it for me

[Kulgar]

Same here, #207 fixed it for me too

[thbar]

@rvm/ansible based on today's testing on a client deployment, I believe this is now fixed (via #207).

I will create a changelog PR to replace this.

[thbar]

See comment above. Advertised in #216, I'll close now.