-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Update devicons to v2.17.0 #1900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@all-contributors please add @joeriddles for code |
I could not determine your intention. Basic usage: @all-contributors please add @Someone for code, doc and infra For other usages see the documentation |
@all-contributors please add @joeriddles for code |
I've put up a pull request to add @joeriddles! 🎉 |
@@ -51,7 +51,7 @@ E62D E72D vorillaz/smashing_magazine.svg smashing_magazine | |||
E62E E72E apachekafka/apachekafka-original.svg apachekafka | |||
E62F E72F apachespark/apachespark-original.svg apachespark | |||
E630 E730 apl/apl-plain.svg apl | |||
E631 E731 appwrite/appwrite-plain.svg appwrite | |||
E631 E731 appwrite/appwrite-original.svg appwrite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are more such changes, substituting original
for plain
.
Did you do that on purpose, of came it out of the analyzer script? 🤔
Thanks for the PR, btw. 💚
Edit:
The script should prefer plain:
def file_with_ending(files, ending):
""" Return the (first) file out of a list of files that has the desired ending """
...
filename = file_with_ending(svgs, 'plain.svg')
if not filename:
filename = file_with_ending(svgs, 'original.svg')
if not filename:
filename = file_with_ending(svgs, 'plain-wordmark.svg')
if not filename:
filename = file_with_ending(svgs, 'original-wordmark.svg')
if not filename:
return False
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you do that on purpose, of came it out of the analyzer script
This was on purpose as some plain
versions were removed/renamed in v2.17.0. For example, appwrite
was renamed to original
here https://github.com/devicons/devicon/pull/2196/files#diff-8fb0089a81b777eae04d6ac8f37becd0a07c41dd808f17e9e90eafb7411a8f60
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see, thanks!
It is unlikely that I have time for an in-depth look before August, sorry.
But your PR is very welcome! It should not take long to review, maybe I can squeeze it in somehow.
At the moment I work from 6 am to 8 pm every day :-(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No rush, let me know if there's anything I can do to help with making review easier. Cheers
Description
Devicons released v2.17.0 two days ago, which introduced many new icons. This PR upgrades devicons from v2.16.0 to v2.17.0.
Requirements / Checklist
If this contains a font/glyph add its origin as background info below (e.g. URL)N/AWhat does this Pull Request (PR) do?
original
instead ofplain
in cases were theplain
file was removed/renamed in v2.17.0.How should this be manually tested?
Download the
devicons.otf
and inspect the new icons in your favorite font app.Any background context you can provide?
What are the relevant tickets (if any)?
#1899
Screenshots (if appropriate or helpful)
New icons, starting at the third one in from the top:
