Skip to content

feat(ipfs): remove usless fields in ipfs api #3453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 26, 2023
Merged

feat(ipfs): remove usless fields in ipfs api #3453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ed40a4
feat: update generated APIs
scaleway-bot Oct 25, 2023
cde4f51
Merge branch 'master' into v1.4171.0
Codelax Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions cmd/scw/testdata/test-all-usage-ipfs-pin-create-by-cid-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,11 @@ USAGE:
scw ipfs pin create-by-cid [arg=value ...]

ARGS:
volume-id Volume ID on which you want to pin your content
cid CID containing the content you want to pin
[origins.{index}] Node containing the content you want to pin
[name] Pin name
[pin-options.required-zones.{index}]
[pin-options.replication-count]
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)
volume-id Volume ID on which you want to pin your content
cid CID containing the content you want to pin
[origins.{index}] Node containing the content you want to pin
[name] Pin name
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)

FLAGS:
-h, --help help for create-by-cid
Expand Down
10 changes: 4 additions & 6 deletions cmd/scw/testdata/test-all-usage-ipfs-pin-create-by-url-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,10 @@ USAGE:
scw ipfs pin create-by-url [arg=value ...]

ARGS:
volume-id Volume ID on which you want to pin your content
url URL containing the content you want to pin
[name] Pin name
[pin-options.required-zones.{index}]
[pin-options.replication-count]
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)
volume-id Volume ID on which you want to pin your content
url URL containing the content you want to pin
[name] Pin name
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)

FLAGS:
-h, --help help for create-by-url
Expand Down
4 changes: 0 additions & 4 deletions docs/commands/ipfs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,6 @@ scw ipfs pin create-by-cid [arg=value ...]
| cid | Required | CID containing the content you want to pin |
| origins.{index} | | Node containing the content you want to pin |
| name | | Pin name |
| pin-options.required-zones.{index} | | |
| pin-options.replication-count | | |
| region | Default: `fr-par`<br />One of: `fr-par`, `nl-ams`, `pl-waw` | Region to target. If none is passed will use default region from the config |


Expand All @@ -72,8 +70,6 @@ scw ipfs pin create-by-url [arg=value ...]
| volume-id | Required | Volume ID on which you want to pin your content |
| url | Required | URL containing the content you want to pin |
| name | | Pin name |
| pin-options.required-zones.{index} | | |
| pin-options.replication-count | | |
| region | Default: `fr-par`<br />One of: `fr-par`, `nl-ams`, `pl-waw` | Region to target. If none is passed will use default region from the config |


Expand Down
24 changes: 0 additions & 24 deletions internal/namespaces/ipfs/v1alpha1/ipfs_cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,18 +279,6 @@ A pin is defined by its ID (UUID), its status (queued, pinning, pinned or failed
Deprecated: false,
Positional: false,
},
{
Name: "pin-options.required-zones.{index}",
Required: false,
Deprecated: false,
Positional: false,
},
{
Name: "pin-options.replication-count",
Required: false,
Deprecated: false,
Positional: false,
},
core.RegionArgSpec(scw.RegionFrPar, scw.RegionNlAms, scw.RegionPlWaw),
},
Run: func(ctx context.Context, args interface{}) (i interface{}, e error) {
Expand Down Expand Up @@ -346,18 +334,6 @@ A pin is defined by its ID (UUID), its status (queued, pinning, pinned or failed
Deprecated: false,
Positional: false,
},
{
Name: "pin-options.required-zones.{index}",
Required: false,
Deprecated: false,
Positional: false,
},
{
Name: "pin-options.replication-count",
Required: false,
Deprecated: false,
Positional: false,
},
core.RegionArgSpec(scw.RegionFrPar, scw.RegionNlAms, scw.RegionPlWaw),
},
Run: func(ctx context.Context, args interface{}) (i interface{}, e error) {
Expand Down