Skip to content

Conversation

Laure-di
Copy link
Contributor

close #3010

@Laure-di Laure-di force-pushed the feat/autocomplete-vpcgw-private-network-id branch 2 times, most recently from cc1c628 to 742a0a5 Compare February 15, 2024 11:16
@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2024

Codecov Report

❌ Patch coverage is 26.92308% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.98%. Comparing base (bb53bb3) to head (5e55144).
⚠️ Report is 815 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/autocomplete_utils.go 26.92% 17 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3657      +/-   ##
==========================================
+ Coverage   75.76%   75.98%   +0.22%     
==========================================
  Files         183      184       +1     
  Lines       41276    41494     +218     
==========================================
+ Hits        31272    31530     +258     
+ Misses       8860     8815      -45     
- Partials     1144     1149       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Laure-di Laure-di force-pushed the feat/autocomplete-vpcgw-private-network-id branch 2 times, most recently from a168d9b to 6954d53 Compare February 15, 2024 13:55
@Laure-di Laure-di force-pushed the feat/autocomplete-vpcgw-private-network-id branch from 6954d53 to bfd6e6d Compare February 15, 2024 14:08
remyleone
remyleone previously approved these changes Feb 15, 2024
@remyleone remyleone added this pull request to the merge queue Feb 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 15, 2024
@Laure-di Laure-di force-pushed the feat/autocomplete-vpcgw-private-network-id branch from bfd6e6d to ed3712d Compare February 15, 2024 15:13
@Laure-di Laure-di force-pushed the feat/autocomplete-vpcgw-private-network-id branch from ed3712d to 5e55144 Compare February 15, 2024 15:15
@remyleone remyleone added this pull request to the merge queue Feb 15, 2024
Merged via the queue into scaleway:master with commit 8a15052 Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable completion on private-network-id
4 participants