Skip to content

feat(serverless_jobs): add local storage limit #3658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2024
Merged

feat(serverless_jobs): add local storage limit #3658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cmd/scw/testdata/test-all-usage-jobs-definition-create-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ USAGE:
ARGS:
name=<generated> Name of the job definition
cpu-limit CPU limit of the job
memory-limit Memory limit of the job
memory-limit Memory limit of the job (in MiB)
[local-storage-capacity] Local storage capacity of the job (in MiB)
[image-uri] Image to use for the job
[command] Startup command
[project-id] Project ID to use. If none is passed the default project ID will be used
Expand Down
3 changes: 2 additions & 1 deletion cmd/scw/testdata/test-all-usage-jobs-definition-update-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ ARGS:
job-definition-id UUID of the job definition to update
[name] Name of the job definition
[cpu-limit] CPU limit of the job
[memory-limit] Memory limit of the job
[memory-limit] Memory limit of the job (in MiB)
[local-storage-capacity] Local storage capacity of the job (in MiB)
[image-uri] Image to use for the job
[command] Startup command
[environment-variables.{key}] Environment variables of the job
Expand Down
6 changes: 4 additions & 2 deletions docs/commands/jobs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ scw jobs definition create [arg=value ...]
|------|---|-------------|
| name | Required<br />Default: `<generated>` | Name of the job definition |
| cpu-limit | Required | CPU limit of the job |
| memory-limit | Required | Memory limit of the job |
| memory-limit | Required | Memory limit of the job (in MiB) |
| local-storage-capacity | | Local storage capacity of the job (in MiB) |
| image-uri | | Image to use for the job |
| command | | Startup command |
| project-id | | Project ID to use. If none is passed the default project ID will be used |
Expand Down Expand Up @@ -153,7 +154,8 @@ scw jobs definition update <job-definition-id ...> [arg=value ...]
| job-definition-id | Required | UUID of the job definition to update |
| name | | Name of the job definition |
| cpu-limit | | CPU limit of the job |
| memory-limit | | Memory limit of the job |
| memory-limit | | Memory limit of the job (in MiB) |
| local-storage-capacity | | Local storage capacity of the job (in MiB) |
| image-uri | | Image to use for the job |
| command | | Startup command |
| environment-variables.{key} | | Environment variables of the job |
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ require (
github.com/moby/buildkit v0.11.6
github.com/opencontainers/go-digest v1.0.0
github.com/pkg/errors v0.9.1
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.23.0.20240206155451-64fcc5bbab4d
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.23.0.20240213135046-844b67c59145
github.com/skratchdot/open-golang v0.0.0-20200116055534-eef842397966
github.com/spf13/cobra v1.8.0
github.com/spf13/pflag v1.0.5
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,8 +392,8 @@ github.com/rogpeppe/go-internal v1.11.0 h1:cWPaGQEPrBb5/AsnsZesgZZ9yb1OQ+GOISoDN
github.com/russross/blackfriday/v2 v2.1.0/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06 h1:OkMGxebDjyw0ULyrTYWeN0UNCCkmCWfjPnIA2W6oviI=
github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06/go.mod h1:+ePHsJ1keEjQtpvf9HHw0f4ZeJ0TLRsxhunSI2hYJSs=
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.23.0.20240206155451-64fcc5bbab4d h1:F4MeCGwhzSBwEIdTNh8qtVg5o91qV2N7cFeDv5BBTyQ=
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.23.0.20240206155451-64fcc5bbab4d/go.mod h1:fCa7OJZ/9DRTnOKmxvT6pn+LPWUptQAmHF/SBJUGEcg=
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.23.0.20240213135046-844b67c59145 h1:oC363DWOxN7AN11KO/fdMprXKrGO1pixAtCCOYpUfjk=
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.23.0.20240213135046-844b67c59145/go.mod h1:fCa7OJZ/9DRTnOKmxvT6pn+LPWUptQAmHF/SBJUGEcg=
github.com/sclevine/spec v1.4.0 h1:z/Q9idDcay5m5irkZ28M7PtQM4aOISzOpj4bUPkDee8=
github.com/secure-systems-lab/go-securesystemslib v0.4.0 h1:b23VGrQhTA8cN2CbBw7/FulN9fTtqYUdS5+Oxzt+DUE=
github.com/sergi/go-diff v1.0.0/go.mod h1:0CfEIISq7TuYL3j771MWULgwwjU+GofnZX9QAmXWZgo=
Expand Down
18 changes: 16 additions & 2 deletions internal/namespaces/jobs/v1alpha1/jobs_cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,11 +86,18 @@ func jobsDefinitionCreate() *core.Command {
},
{
Name: "memory-limit",
Short: `Memory limit of the job`,
Short: `Memory limit of the job (in MiB)`,
Required: true,
Deprecated: false,
Positional: false,
},
{
Name: "local-storage-capacity",
Short: `Local storage capacity of the job (in MiB)`,
Required: false,
Deprecated: false,
Positional: false,
},
{
Name: "image-uri",
Short: `Image to use for the job`,
Expand Down Expand Up @@ -260,7 +267,14 @@ func jobsDefinitionUpdate() *core.Command {
},
{
Name: "memory-limit",
Short: `Memory limit of the job`,
Short: `Memory limit of the job (in MiB)`,
Required: false,
Deprecated: false,
Positional: false,
},
{
Name: "local-storage-capacity",
Short: `Local storage capacity of the job (in MiB)`,
Required: false,
Deprecated: false,
Positional: false,
Expand Down