Skip to content

Conversation

jremy42
Copy link
Contributor

@jremy42 jremy42 commented Mar 6, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


close #2897

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 18.66667% with 122 lines in your changes are missing coverage. Please review.

Project coverage is 75.68%. Comparing base (79a1c0a) to head (043eef3).

Files Patch % Lines
internal/namespaces/mnq/v1beta1/custom_sns.go 10.90% 49 Missing ⚠️
internal/namespaces/mnq/v1beta1/custom_sqs.go 11.11% 48 Missing ⚠️
internal/namespaces/mnq/v1beta1/custom_nats.go 19.35% 25 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3700      +/-   ##
==========================================
- Coverage   75.88%   75.68%   -0.20%     
==========================================
  Files         194      196       +2     
  Lines       43163    43313     +150     
==========================================
+ Hits        32754    32782      +28     
- Misses       9207     9329     +122     
  Partials     1202     1202              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jremy42 jremy42 force-pushed the feat/add-autocompletion-for-credentials-and-accounts branch from 043eef3 to 6252da1 Compare March 6, 2024 15:11
@remyleone remyleone added this pull request to the merge queue Mar 13, 2024
Merged via the queue into scaleway:master with commit 833fb65 Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no autocomplete available for mnq get/delete/update credentials
3 participants