Skip to content

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented May 21, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


@Codelax Codelax added enhancement instance Instance issues, bugs and feature requests labels May 21, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 73.10%. Comparing base (5bf53e0) to head (a553f83).
Report is 58 commits behind head on master.

Files Patch % Lines
internal/namespaces/instance/v1/helpers_types.go 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3823      +/-   ##
==========================================
- Coverage   75.45%   73.10%   -2.35%     
==========================================
  Files         202      280      +78     
  Lines       44323    49665    +5342     
==========================================
+ Hits        33444    36309    +2865     
- Misses       9653    11868    +2215     
- Partials     1226     1488     +262     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Codelax Codelax added this pull request to the merge queue May 23, 2024
Merged via the queue into scaleway:master with commit e00d962 May 23, 2024
@Codelax Codelax deleted the feat/instance-type-complete-with-api branch May 23, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants