Skip to content

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Sep 11, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


@github-actions github-actions bot added the instance Instance issues, bugs and feature requests label Sep 11, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.44%. Comparing base (5bf53e0) to head (405e2d3).
Report is 250 commits behind head on master.

Files with missing lines Patch % Lines
internal/namespaces/instance/v1/custom_server.go 0.00% 1 Missing ⚠️
...spaces/instance/v1/custom_server_create_builder.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4122      +/-   ##
==========================================
- Coverage   75.45%   72.44%   -3.01%     
==========================================
  Files         202      289      +87     
  Lines       44323    53928    +9605     
==========================================
+ Hits        33444    39069    +5625     
- Misses       9653    13258    +3605     
- Partials     1226     1601     +375     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remyleone remyleone added this pull request to the merge queue Sep 13, 2024
Merged via the queue into scaleway:master with commit 269ede4 Sep 13, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants