Pike theme #103
Open
Pike theme #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pike merge
…r and mobile sidebar
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new "Pike" theme to the snap-preact component library. The theme follows the established pattern of the existing themes (base, bocachica, snappy, snapnco) and provides comprehensive styling for all component types including atoms, molecules, organisms, and templates.
Key changes:
- Complete Pike theme implementation with custom styling and color scheme
- Theme registration in library store and storybook configuration
- Demo configuration updates to use the new Pike theme by default
Reviewed Changes
Copilot reviewed 76 out of 76 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/snap-preact/src/Templates/Stores/LibraryStore.ts | Adds Pike theme import and registration in the theme library store |
| packages/snap-preact/components/src/themes/pike/* | Complete Pike theme implementation including components, styling, and configuration |
| packages/snap-preact/components/src/themes/index.ts | Exports Pike theme for external use |
| packages/snap-preact/components/.storybook/preview.tsx | Integrates Pike theme into Storybook development environment |
| packages/snap-preact-demo/templates/src/* | Updates demo configuration to use Pike theme as default |
| snappy: async () => { | ||
| return this.themes.snappy || (this.themes.snappy = (await import('./library/themes/snappy')).snappy); | ||
| pike: async () => { | ||
| return this.themes.pike || (this.themes.pike = (await import('../../../components/src/themes/pike/pike')).pike); |
There was a problem hiding this comment.
The Pike theme import path uses a different structure compared to other themes. Consider using a consistent import path pattern like './library/themes/pike' to match the existing theme organization.
Suggested change
| return this.themes.pike || (this.themes.pike = (await import('../../../components/src/themes/pike/pike')).pike); | |
| return this.themes.pike || (this.themes.pike = (await import('./library/themes/pike')).pike); |
Copilot uses AI. Check for mistakes.
refactor(merge develop): merge in develop
refactor(themes/pike): tweaks and clean up to pike theme
refactor(pike_theme): small tweaks to pike theme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.