Fix schedule duplication issue in backup/restore functionality #3277
+30,910
−30,775
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When restoring a project from backup, schedules were being duplicated due to two separate creation paths:
Schedules
arrayThis resulted in duplicate schedules with identical data but different IDs, and the
makeUniqueNames()
function would generate arbitrary random names for the duplicates.Root Cause
The issue occurred because:
BackupSchedule
was missing the requiredGetName()
method from theBackupEntry
interfaceBackupTemplate.Restore()
unconditionally created schedules for templates with cron fieldsSolution
GetName()
method forBackupSchedule
to satisfy theBackupEntry
interfaceRestoreWithScheduleHandling()
method while preserving the originalRestore()
behaviorThe fix ensures that when both template cron settings and explicit schedules exist in a backup, only the explicit schedule is restored with its proper name, preventing duplication and random naming.
Fixes #3172
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.