Skip to content

fix: add workaround for providers.gradleProperty for pre-7.4 Gradle versions #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2025
Merged

fix: add workaround for providers.gradleProperty for pre-7.4 Gradle versions #924

merged 1 commit into from
Mar 7, 2025

Conversation

vlsi
Copy link
Collaborator

@vlsi vlsi commented Mar 6, 2025 •
edited
Loading

Summary

Previous Gradle versions required .forUseAtConfigurationTime(), so let's add it.

The PR fixes

FAILURE   0.6sec, dev.sigstore.gradle.SigstorePublishSignTest > sign file(TestedGradleAndSigstoreJava)[1], [1] case=TestedGradleAndSigstoreJava(gradle=TestedGradle(version=Gradle 7.3, configurationCache=ON, projectIsolation=ON), sigstoreJava=LocallyBuiltVersion(version=1.4.0-SNAPSHOT))
    org.gradle.testkit.runner.UnexpectedBuildFailure: Unexpected build execution failure in /tmp/junit-12010571174430091447 with arguments [publishAllPublicationsToTmpRepository, -s]
    Caused by: java.lang.IllegalStateException: Cannot obtain value from provider of Gradle property 'dev.sigstore.sign.remove.sigstore.json.asc' at configuration time.
    Use a provider returned by 'forUseAtConfigurationTime()' instead.
    	at org.gradle.api.internal.provider.DefaultValueSourceProviderFactory$NonConfigurationTimeProvider.vetoAtConfigurationTime(DefaultValueSourceProviderFactory.java:198)
    	at org.gradle.api.internal.provider.DefaultValueSourceProviderFactory$ValueSourceProvider.calculateOwnValue(DefaultValueSourceProviderFactory.java:298)
    	at org.gradle.api.internal.provider.AbstractMinimalProvider.getOrNull(AbstractMinimalProvider.java:93)
    	at dev.sigstore.sign.SigstoreSignExtension.sign(SigstoreSignExtension.kt:87)
    	at dev.sigstore.sign.SigstoreSignExtension.sign(SigstoreSignExtension.kt:67)
    	at dev.sigstore.sign.SigstoreSignExtension$sign$1.execute(SigstoreSignExtension.kt:56)
    	at dev.sigstore.sign.SigstoreSignExtension$sign$1.execute(SigstoreSignExtension.kt:55)
    	at org.gradle.configuration.internal.DefaultUserCodeApplicationContext$CurrentApplication$1.execute(DefaultUserCodeApplicationContext.java:123)

Release Note

NONE

Documentation

NONE

@vlsi vlsi requested a review from loosebazooka March 6, 2025 13:46
@vlsi
fix: add workaround for providers.gradleProperty for pre-7.4 Gradle v…
b8d8ccb 
…ersions

Previous versions required .forUseAtConfigurationTime()

Signed-off-by: Vladimir Sitnikov <[email protected]>
loosebazooka
loosebazooka approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member

@loosebazooka loosebazooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have test coverage for this?

@vlsi
Copy link
Collaborator Author

vlsi commented Mar 7, 2025

The current CI fails: https://github.com/sigstore/sigstore-java/actions/runs/13698851080/job/38307460744#step:7:764

@vlsi vlsi merged commit 617ea59 into sigstore:main Mar 7, 2025
12 of 13 checks passed
@vlsi vlsi deleted the prop branch March 7, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loosebazooka loosebazooka loosebazooka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlsi @loosebazooka