Add artifact validation and staging tests to timestamp verifier #977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loosebazooka
reviewed
Jun 2, 2025
sigstore-java/src/main/java/dev/sigstore/timestamp/client/TimestampVerifier.java
Outdated
Show resolved
Hide resolved
sigstore-java/src/main/java/dev/sigstore/timestamp/client/TimestampVerifier.java
Outdated
Show resolved
Hide resolved
aaronlew02
force-pushed
the
timestamp-verifier
branch
from
53e826c to
66b30ed
Compare
loosebazooka
reviewed
Jun 3, 2025
sigstore-java/src/main/java/dev/sigstore/timestamp/client/HashAlgorithmException.java
Outdated
Show resolved
Hide resolved
sigstore-java/src/main/java/dev/sigstore/timestamp/client/TimestampVerifier.java
Outdated
Show resolved
Hide resolved
aaronlew02
force-pushed
the
timestamp-verifier
branch
from
66b30ed to
ece9538
Compare
Signed-off-by: Aaron Lew <[email protected]>
aaronlew02
force-pushed
the
timestamp-verifier
branch
from
ece9538 to
fd9d69c
Compare
loosebazooka
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #959
Summary
This changes enables artifact validation (i.e., confirmation that the message imprint digest of a timestamp matches the artifact digest sent in the request) in the timestamp verifier.
This change also updates the verifier's tests to include staging URIs for the Sigstore TSA, as timestamping functionality is currently restricted to staging environments.