Add RFC3161 timestamps to bundle reader and writer #978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loosebazooka
reviewed
Jun 4, 2025
sigstore-java/src/main/java/dev/sigstore/bundle/BundleWriter.java
Outdated
Show resolved
Hide resolved
aaronlew02
force-pushed
the
reader-writer
branch
2 times, most recently
from
64197fb to
49e25e6
Compare
loosebazooka
reviewed
Jun 4, 2025
| @@ -110,6 +113,11 @@ private static VerificationMaterial.Builder buildVerificationMaterial(Bundle bun | |||
| "Exactly 1 rekor entry must be present in the signing result"); | |||
| } | |||
| builder.addTlogEntries(buildTlogEntries(bundle.getEntries().get(0))); | |||
| Optional<TimestampVerificationData> timestampData = | |||
There was a problem hiding this comment.
There might be an Optional.ifPresent shortcut you can use here
buildTimestampVerificationData(bundle.getTimestamps()).ifPresent(data -> builder.setTimestampVerificationData(data)
Signed-off-by: Aaron Lew <[email protected]>
loosebazooka
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #959
Summary
This change allows for the inclusion of RFC3161 timestamps in a
Bundlevia theBundleReaderandBundleWriter.