Push signing config through all our clients #981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlsi
reviewed
Jun 5, 2025
...e-gradle/sigstore-gradle-sign-base-plugin/src/test/kotlin/dev/sigstore/gradle/OidcDslTest.kt
Outdated
Show resolved
Hide resolved
vlsi
reviewed
Jun 5, 2025
loosebazooka
force-pushed
the
plumb-signing-config
branch
from
79a5c14 to
4a53748
Compare
sigstore-gradle now delegates to oidc config is sigstore-java for the default case. Signed-off-by: Appu Goundan <[email protected]>
loosebazooka
force-pushed
the
plumb-signing-config
branch
from
4a53748 to
3a17b3d
Compare
aaronlew02
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sigstore-gradle now delegates to oidc config is sigstore-java for the default case.
needs a little more work after all the TSA stuff is submittedrebased on TSA@vlsi might need a check on the changes in gradle.