Skip to content

Restoring require('ws') as separate expression for browserify. #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2016
Merged

Restoring require('ws') as separate expression for browserify. #418

merged 1 commit into from
Aug 5, 2016

Conversation

darrachequesne
Copy link
Member

Cherry-pick from #397.

Reference #390 (comment)

@rauchg, @kapouer Guys, this PR breaks the ability to pack socket.io / engine.io with browserify because it is not able to detect the module name anymore. I.e. every time require with variable breaks it. I'm going to fix it in #397 to avoid creating a new PR.

Closes #397

@darrachequesne darrachequesne merged commit fadeb7d into socketio:master Aug 5, 2016
@darrachequesne darrachequesne added this to the 1.7.0 milestone Oct 20, 2016
@darrachequesne darrachequesne mentioned this pull request Dec 10, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@darrachequesne @palavrov