Rename ServerRequest to IncomingMessage in readme #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you also update the jsdoc here https://github.com/socketio/engine.io/blob/master/lib/server.js please? |
|
@DominikPalo friendly ping |
|
Thanks, done |
darrachequesne
pushed a commit
that referenced
this pull request
Dec 5, 2016
`http.ServerRequest` did refer to the HTTP API of Nodejs prior to v0.10
|
Merged as 8450d03. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behaviour
Documentation uses
http.ServerRequestfor node request objectsNew behaviour
Documentation uses
http.IncomingMessagefor node request objectsOther information (e.g. related issues)
According to the node http documentation, correct name for a node request class is
IncomingMessage.