Fix Host Function #1844
Merged
Fix Host Function #1844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piaskowyk
approved these changes
Mar 18, 2021
| @@ -239,8 +250,10 @@ jsi::Value ShareableValue::toJSValue(jsi::Runtime &rt) { | |||
| } | |||
| case ValueType::HostFunctionType: { | |||
| auto hostFunctionWrapper = ValueWrapper::asHostFunctionWrapper(valueContainer); | |||
| if (hostFunctionWrapper->hostRuntime == &rt) { | |||
| auto hostRuntime = hostFunctionWrapper->value->hostRuntime; | |||
There was a problem hiding this comment.
I think we can use here auto & instead of auto to avoid unnecessary copying of objects.
|
You made my day 🔥 Looking forward to examples and new release 🤩 |
piaskowyk
added a commit
that referenced
this pull request
Mar 23, 2021
## Description Method `std::shared_ptr<jsi::Function> get()` from `struct HostFunctionHandler : jsi::HostObject` had name conflict wtih `virtual Value get(Runtime&, const PropNameID& name)` from `jsi::HostObject` and this crashed CI and compilation for android. Related with: #1844 ## Checklist - [x] Ensured that CI passes
|
Hi, is this pr included in v2.0.1? Looks like the problem is still continue. |
2 tasks
|
Hi, I am following issue for my package. It is solved with v2.1.0 actually. When I try it on Expo project with same version (v2.1.0), problem still exist. Not sure if I open an issue in Expo. Wanted to let you know. |
This was referenced May 22, 2021
1 task
This was referenced Jul 13, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #1758
Currently, when we send callback function to UI thread and then back to RN then we will get function wrapper that checks is somebody uses runOnJS. In order to solve the problem, I've added logic that attaches additional info to a function wrapper that allows to get original callback.
Changes
Test code and steps to reproduce
Checklist