-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: get static feature flags in JS #8096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
reviewed
Aug 20, 2025
packages/react-native-worklets/src/featureFlags/getStaticFlag.ts
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/src/featureFlags/getStaticFlag.ts
Outdated
Show resolved
Hide resolved
tvos example can you stop failing on pod install step it's annoying thank you |
piaskowyk
approved these changes
Aug 22, 2025
packages/react-native-reanimated/Common/cpp/reanimated/NativeModules/ReanimatedModuleProxy.cpp
Show resolved
Hide resolved
Could you also add informations about this new feature to Feature Flag documentation? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding APIs to access static feature flags. While we could opt for ahead of runtime solutions, I figured that a runtime solution is good enough for the first iteration.
Test plan
Added a runtime test suite, typetests and internal static type checking.