Deprecate .modulo(), add .smod(), .rem() #365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is another API-incompatible change in recent history, and we do not want to touch this location twice (also from user perspective), A new major version of JavaSMT is required anyway.
The previous implementation did not correctly encode smodule-by-zero. Additionally, using a basis of srem instead of urem allows to simplify the encoding.
The hardest part of programming is documentation :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #360, the
.modulo()method on the BitvectorFormulaManager API is misleading, because it creates a{s,u}remoperation. Therefore, we deprecate the method, and add separate.smod()and.rem()methods.The (now deprecated)
.modulo()operation delegates to the.rem()operation.