Add support for Worker instances and module URLs in FsaNodeSyncAdapterWorker #1118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FsaNodeSyncAdapterWorker.start()
method now accepts either a Worker instance or a URL string, enabling compatibility with modern build tools like Vite that require module workers.Changes Made
url: string
tourlOrWorker: string | Worker
type=module
to create workers with{ type: 'module' }
optionsUsage Examples
Traditional URL (backward compatible):
Module URL (for Vite and similar frameworks):
Pre-created Worker instance:
The implementation automatically detects URLs containing
type=module
and creates the worker with the appropriate options, making the fsa-to-node module compatible with modern bundlers that use ES module workers.Fixes #974.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.