feat: fix fs.promises.glob return type to match Node.js API #1162
+137
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
fs.promises.glob
method in memfs was incorrectly returningPromise<string[]>
instead of the Node.js standardAsyncIterableIterator<string>
. This made it incompatible with the native Node.js API and prevented users from using the standardfor await...of
iteration pattern.What was wrong
What's fixed
Implementation
GlobAsyncIterator
: A custom AsyncIterator implementation that yields glob results incrementallywithFileTypes
and multiple patternswithFileTypes
option and multiple pattern supportThe fix ensures memfs now perfectly matches the Node.js
fs.promises.glob
API, enabling seamless migration between real and in-memory file systems.Fixes #1161.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.