fix(types): computed field and star selector #626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soedirgo
reviewed
Jul 21, 2025
| { | ||
| type Json = unknown | ||
|
|
||
| type Database = { |
There was a problem hiding this comment.
Can we reuse the generated types instead of using a mock?
There was a problem hiding this comment.
I don't wanted to change the schema to test "corner cases" as long as the main cases where handled by the integrations tests.
I've updated the tests to re-use the generated types where possible, and kept the "mock" only for the "multiples computed fields" test case. LMK if that work for you 👍
soedirgo
approved these changes
Jul 22, 2025
|
🎉 This PR is included in version 1.21.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?