feat: Progressive Profiling #11
Conversation
🦋 Changeset detectedLatest commit: 2f1a756 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
# Conflicts: # package-lock.json # package.json
packages/progressive-profiling-nodejs/src/progressive-profiling-service.ts
Outdated
Show resolved
Hide resolved
packages/progressive-profiling-nodejs/src/progressive-profiling-service.ts
Outdated
Show resolved
Hide resolved
packages/progressive-profiling-nodejs/src/progressive-profiling-service.ts
Outdated
Show resolved
Hide resolved
| fetchValue: async (userId) => { | ||
| const implementation = Implementation.getInstanceOrThrow(); | ||
| const userMetadata = await implementation.metadata.get(userId); | ||
| return implementation.existingSections.every( |
There was a problem hiding this comment.
Please make this use the overrideable isSectionCompleted function.
There was a problem hiding this comment.
the problem with using isSectionCompleted (or the former areAllSectionsCompleted or getSections is that i don't have access to the session object to pass it as a param - this is the reason i reverted to this implementation
There was a problem hiding this comment.
i can make use of it, but i'd have to make the session param optional, which for that method, business logic dictates that it should not be (since you can only check if the sections are completed when a session exists)
There was a problem hiding this comment.
Why is that specific to a session? Isn't it just based on the userid?
# Conflicts: # package-lock.json
coolbueb
changed the title
# Conflicts: # package-lock.json # package.json
No description provided.