Skip to content

Conversation

ackintosh
Copy link
Contributor

@ackintosh ackintosh commented Feb 16, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

refs #7200

"test" should not contain real codes.

By merging this PR, the test directory is completely cleaned and all the test code is integrated into tests.

The same test code as deleted is in the 'tests' directory.
rm -rf samples/client/petstore/php/SwaggerClient-php/test && bin/php-petstore.sh
@ackintosh
Copy link
Contributor Author

@wing328 wing328 merged commit be14e02 into swagger-api:master Feb 22, 2018
@wing328 wing328 added this to the v2.4.0 milestone Feb 22, 2018
@ackintosh ackintosh deleted the cleanup-test branch February 24, 2018 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants