Skip to content

Conversation

jmini
Copy link
Contributor

@jmini jmini commented Mar 21, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

CC: @bbdouglas (2017/07) @JFCote (2017/08) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01)

Description of the PR

This is a fix for Issue #7853. Because most of the templates are shared with the jaxrs templates, It makes sense to share the postProcessOperations method.

In addition, while I was working on swagger-api/swagger-codegen-generators#29 and on #7854, I have noticed that the bin/jaxrs-cxf-client-petstore.sh was not generating the correct example. I have first fixed this script and generated the corresponding example in order to see the error (see 1b2d918) Then I have proposed my fix. The results can be seen in 51deb9a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants