Issue 5542, always generate pom and readme

[inidona]

#5542 not working for us

InterfaceOnly=true for not generating pom.xml not works in every situation.

PR checklist

• Read the contribution guidelines.
• Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
• Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
• Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)
Issue 5542, i added the additionalParameter "generateMeta=[true|false]" for controling generation of pom.xml and README.md. The generation of pom.xml depending on parameter interfaceOnly did not work for our situation. I generated with -DgenerateMeta=true and false

false
[main] INFO io.swagger.codegen.AbstractGenerator - writing file ...XXXResponse.java
[main] INFO io.swagger.codegen.AbstractGenerator - writing file ...XXXApi.java
[main] INFO io.swagger.codegen.AbstractGenerator - writing file ...swagger/.swagger-codegen/VERSION

and true
[main] INFO io.swagger.codegen.AbstractGenerator - writing file ...XXXResponse.java
[main] INFO io.swagger.codegen.AbstractGenerator - writing file ...XXXApi.java
[main] INFO io.swagger.codegen.AbstractGenerator - writing file ...swagger/pom.xml
[main] INFO io.swagger.codegen.AbstractGenerator - writing file ...swagger/README.md
[main] INFO io.swagger.codegen.AbstractGenerator - writing file ...swagger/.swagger-codegen/VERSION

@jeff9finger could you review this PR ?
@bbdouglas (2017/07) @JFCote (2017/08) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09)

[wing328]

What about using .swagger-codegen-ignore to skip files that you don't need?

[inidona]

I need this files. In actual master branch this files were not generated with additionalParameter interfaceOnly=true, because of this i added the new parameter generateMeta and when this is true the pom.xml and README.md will be generated. It is now possible to control with a parameter to generate pom.xml, README.md or not, and not implicit with interfaceOnly=true|false

[wing328]

Instead of introducing another option, what about including those files when interfaceOnly=true? (users can use .swagger-codegen-ignore to skip those during code generation)

We want to avoid too many options to customize the output.

[inidona]

this is ok for me, so i have to revert the part of PR https://github.com/swagger-api/swagger-codegen/pull/5545/files at the location where the files were generated ?
So .swagger-codegen-ignore was the better option for the original poster ?

[inidona]

@wing328 can you tell me what i should do now ?

[wing328]

@inidona If I understand correctly, you will need to change the behavior of the InterfaceOnly=true option to also generate the pom file.

[inidona]

@wing328 yes, i would generate the pom.xml always.

[wing328]

@inidona sorry that I wasn't clear. My suggest is to avoid adding another option "GENERATE_META" and rather update the existing "INTERFACE_ONLY" option to generate the pom.xml as well.

Please reach me via the email address in my Github profile if you can to dicuss this further (email is much easier to draw my attention than a discussion in the issue tracker)

[inidona]

@wing328 i made my changes

[inidona]

@jeff9finger could you review this PR ?
@bbdouglas (2017/07) @JFCote (2017/08) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09)

[jeff9finger]

This change seems to always include pom.xml and README.md. There is no condition for interfaceOnly == true.

If I understand the conversation correctly, these files are only supposed to be included when interfaceOnly == true

[inidona]

Hi, no i talked with wing328 and we have consent that the files should always been generated. If a user don't won't these files he have to use .swagger-codegen-ignore

thanks
andreas

[jeff9finger]

OK. Thanks for the clarification.

LGTM 👍