Allow to set values with setApiPackage(..) and setModelPackage(..) #8013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue description in #8004.
getInvokerPackage()added (to be consistent with other genertors already having this method with c100995setApiPackage(..)andsetModelPackage(..)are now taken in account [1][1] As I wrote it in #8004, my change is limited to all
javagenerators (includingandroid-client). I now have there the same behavior as for the PHP generators. See AbstractPhpCodegenTest.java for a reference: no matter if you set the values with the setters or with the map, they will be available (when you read them in the map or with the getters)After this change you have a similar behavior for the java generators (see the corresponding test cases)