[codegen][java]Issue 8055: create javadoc and source jar from gradle build #8056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creating javadoc and source jar fieles
inidona
changed the title
|
@bbdouglas (2017/07) @JFCote (2017/08) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) please review |
JFCote
approved these changes
Apr 23, 2018
| } | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Not sure why we need 3 empty lines here.
There was a problem hiding this comment.
you are right, i removed 2 lines now because of the other formattings in the file
|
LGTM 👍 |
|
@wing328 is it possible to merge ? |
|
@wing328 ping |
|
@wing328 whats wrong with this pr ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)
#8055 creates sources.jar and javadoc jar from gradlebuild for deploying to jfrog public snapshot repository