Fix for Issue https://github.com/swagger-api/swagger-codegen/issues/8339

[kunal-pmj]

PR checklist

• Read the contribution guidelines.
• Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
• Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
• Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

#8339
Constant Values for the QueryParameter are not taken into account while generating the TypeScript Code-Angular code

[kunal-pmj]

Any Idea how to assign a reviewer to this Pull Request?

[HugoMario]

hello @kunal-pmj , thanks for your PR, i'll take a time to review!

[kunal-pmj]

Thanks @HugoMario

[HugoMario]

copying same comment here:

Hey again @kunal-pmj, this LGTM, i would just recommend to edit the petstore sample adding this case, only if it's not present. and based on this, update the typescript-angular samples. wdyt?

i could give you a hand if you need help.

[kunal-pmj]

Hi @HugoMario

I have added the case to the petstore sample. However, I see that there are many samples across different angular versions. Do I need to regenerate them all with my change?

Thanks
Kunal

[HugoMario]

i think one sample is ok, just to confirm you're changes works fine.

[kunal-pmj]

Hi @HugoMario

All the Typescript sample generators under bin/ and bin/windows directories use the petstore 2.0 specification and NOT the petsore specification with fake path where I had added the api. I tested the code generation for typescript-angular-v4.3 using petsore specification with fake path and I can see the fix working fine, in terms of code generation.
In order keep the samples generators for Typescript in sync with the code fix, Where Should I make the changes?

• Should I change the Typescript test generators to use petsore specification with fake path

or

• Add the case to petstore 2.0 specification as well

or none of these would be necessary?

Thanks
Kunal

[kunal-pmj]

Hi @HugoMario

Can you help by answering questions from my previous update?

Thanks
Kunal

[HugoMario]

hey @kunal-pmj sorry for delay, these have been crazy busy days, i think the best approach is to have another petstore 2.0 specification with your changes and use it at least in one sample.

using petsore specification with fake path is also a good choice, but i think it would required to update samples with changes not related to your fix.

[kunal-pmj]

Hi @HugoMario
Kindly review the changes.
I have added a new petstore specification and updated the typescript angular 4.3 non

Thanks
Kunal

[kunal-pmj]

Tests are green now. removed leading space from the petstore specification

[kunal-pmj]

Hi @HugoMario

Can I have your review Comments?

thanks
Kunal

[HugoMario]

sure, i'll take a look on this today and let you know.

[kunal-pmj]

Hi @HugoMario

Do you want me to cover some other test?

Thanks
Kunal

[HugoMario]

hi @kunal-pmj LGTM, thanks a lot for your effort and patience, really sorry for this delay