Only remove duplicate Tailwind classes #277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
changed the title
|
Thanks! I'd planned to make this improvement this week alongside improving duplicate removal such that it only applies to Tailwind classes but this gave me the push to go ahead and get that done. 🔥 |
bronisMateusz
pushed a commit
to bronisMateusz/prettier-plugin-tailwindcss-drupal
that referenced
this pull request
Apr 16, 2025
* improve remove duplicate classes * replace indexOf by Set * Simplify code * Refactor * Remove duplicates after sorting * Only remove duplicates of known classes * Rename vars * Tweak comment * Tweak var names * wip * Move duplicate removal to sorting routine * Refactor * Refactor * Tweak comment * Cleanup * Update changelog --------- Co-authored-by: Jordan Pittman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The change improves the performance of removing duplicated classNames. In this pull request, I replace the indexOf and splice functions, which have O(n) time complexity, with two separate array filters and a Set().
Comparison
Before Change: O(n^2) due to the nested indexOf and splice operations within the filter method.
After Change: O(n) due to the use of a Set for constant-time duplicate checks and separate filtering steps.