olly trace: ingest custom events #17
Conversation
|
How did you test this? With 5.1.0~alpha2, [ERROR] The compilation of core.v0.16.0 failed at "dune build -p core -j 7".
#=== ERROR while compiling core.v0.16.0 =======================================#
# context 2.1.3 | macos/arm64 | ocaml-base-compiler.5.1.0~alpha2 | https://opam.ocaml.org#7b30d632
# path ~/.opam/5.1.0~alpha2/.opam-switch/build/core.v0.16.0
# command ~/.opam/opam-init/hooks/sandbox.sh build dune build -p core -j 7
# exit-code 1
# env-file ~/.opam/log/core-97555-cfb0d4.env
# output-file ~/.opam/log/core-97555-cfb0d4.out
### output ###
# should be applied to '()'; using '(struct end)' is deprecated.
# [...]
# File "_none_", line 1:
# Warning 73 [generative-application-expects-unit]: A generative functor
# should be applied to '()'; using '(struct end)' is deprecated.
#
# File "_none_", line 1:
# Warning 73 [generative-application-expects-unit]: A generative functor
# should be applied to '()'; using '(struct end)' is deprecated.
#
# File "_none_", line 1:
# Warning 73 [generative-application-expects-unit]: A generative functor
# should be applied to '()'; using '(struct end)' is deprecated.
<><> Error report <><><><><><><><><><><><><><><><><><><><><><><><><><><><><><><>
+- The following actions failed
| - build core v0.16.0
+-
- No changes have been performed |
|
This failure on arm64 and mac is odd - FWIW, I was seeing the same error on #16 as well, it wasn't introduced by this PR. I have access to an arm64 machine, will try to reproduce this locally. |
|
@kayceesrk I didn't test the 5.1 alpha so no idea why core is not building there. My tests were done on a 5.0 compiler with the custom events patch: https://github.com/TheLortex/ocaml/tree/custom-events-5.0-rc1. |
|
@kayceesrk I don't see any errors on |
Sounds good to me. |
|
Is this PR good to be merged @TheLortex @Sudha247? |
| let init () = () in | ||
| let cleanup () = Trace.close trace_file in | ||
| olly ~runtime_begin ~runtime_end ~init ~lifecycle ~cleanup exec_args | ||
| olly ~extra ~runtime_begin ~runtime_end ~init ~lifecycle ~cleanup |
There was a problem hiding this comment.
Did not do a full review. Do we want to add custom events to json as well?
There was a problem hiding this comment.
For completeness sake, we should. This can be done as a separate PR if need be, but an issue must be created before we merge this PR.
CHANGES: * Custom events for json (tarides/runtime_events_tools#24, @Sudha247) * Improvements to correct gc-stats (tarides/runtime_events_tools#19, @Sudha247) * olly trace: ingest custom events starting from OCaml 5.1 (tarides/runtime_events_tools#17, @TheLortex)
CHANGES: * Custom events for json (tarides/runtime_events_tools#24, @Sudha247) * Improvements to correct gc-stats (tarides/runtime_events_tools#19, @Sudha247) * olly trace: ingest custom events starting from OCaml 5.1 (tarides/runtime_events_tools#17, @TheLortex)
In 5.1 programmers will be able to add other runtime events. This PR modifies
olly traceso that it includes custom events of common types (unit, int, span).Conditional compilation was used to make it work on 5.0.