Added --output option to redirect olly printing #5
Conversation
| @@ -225,6 +227,17 @@ let () = | |||
| Arg.(value & flag & info [ "json" ] ~docv:"json" ~doc) | |||
| in | |||
|
|
|||
| let output_option = | |||
| let doc = | |||
| "Redirect the output of `olly` to specified file. The output of the \ | |||
There was a problem hiding this comment.
What does "output of the command is not redirected" mean?
There was a problem hiding this comment.
If prog.exe prints on stdout and/or stderr, then olly latency -o some_file prog.exe will print the latency info in some_file, but the original prints will still go to stdout/stderr
There was a problem hiding this comment.
It might be useful to add a description in the PR message to indicate how this command works like ^^.
|
Just realized my shenanigans with the filename make little sense in olly, I'll stick to making a more precise script in sandmark |
|
My last commit here is a partial revert, as I remove the printing of the name altogether. It was messy and in our use-case where |
CHANGES: * Fix dependencies (tarides/runtime_events_tools#14, @Sudha247) * Improve JSON output produced by olly gc-stats (tarides/runtime_events_tools#13, @punchagan) * Mention Fuchsia format in the README (tarides/runtime_events_tools#11, @Sudha247) * Gc subcommand (tarides/runtime_events_tools#10, @Sudha247) * Add Fuchsia Trace Format output to olly (tarides/runtime_events_tools#6, @tomjridge) * Added --output option to redirect olly printing (tarides/runtime_events_tools#5, @ElectreAAS) * Added json printing option (tarides/runtime_events_tools#4, @ElectreAAS)
This will come in handy for this sandmark issue