Add an option to control sleep interval between calls to read_poll #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmcgilchrist
force-pushed
the
poll_sleep_2
branch
2 times, most recently
from
2e4a688 to
fbf6f95
Compare
tmcgilchrist
force-pushed
the
poll_sleep_2
branch
from
fbf6f95 to
bd73e55
Compare
tmcgilchrist
added a commit
to tmcgilchrist/opam-repository
that referenced
this pull request
Sep 5, 2025
CHANGES: * Use trace instead of tracing (tarides/runtime_events_tools#57 tarides/runtime_events_tools#59, @patricoferris @tmcgilchrist) * Add an option to control sleep interval between calls to read_poll (tarides/runtime_events_tools#60, @tomjridge @tmcgilchrist)
tmcgilchrist
added a commit
to tmcgilchrist/opam-repository
that referenced
this pull request
Sep 7, 2025
CHANGES: * Use trace instead of tracing (tarides/runtime_events_tools#57 tarides/runtime_events_tools#59, @patricoferris @tmcgilchrist) * Add an option to control sleep interval between calls to read_poll (tarides/runtime_events_tools#60, @tomjridge @tmcgilchrist)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased version of #9
When running Olly against programs that generate many runtime_events, Olly doesn't keep up with reading events from the runtime_events buffer. Providing a lower sleep may result in fewer events being lost, and setting a value of 0.0 skips sleeping altogether (resulting in high CPU usage by Olly).
In my testing using
0.0will keep up with a very busy program with no observable lost events. Lost events could result in incorrect calculation of gc-stats and missing events in trace files.