-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add validation for "ServiceAccountNames" to avoid wrong taskname #2583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation for "ServiceAccountNames" to avoid wrong taskname #2583
Conversation
The following is the coverage report on the affected files.
|
Thank you for this. Could you add unit test coverage? |
…fine with a wrong "taskName Fix issue tektoncd#2582
d4cc28c
to
92f281c
Compare
The following is the coverage report on the affected files.
|
@afrittoli |
/kind bug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fix issue #2582
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes
If define
PipelineRun.Spec.ServiceAccountNames
with a wrongTaskName
(not existed inPipeline
definition), thePipelineRun
will failed withInvalidServiceAccountMappings