Propagate NodeSelector and Tolerations to Affinity Assistant #2743
Conversation
tekton-robot
added
the
kind/feature
tekton-robot
added
the
size/M
|
This PR cannot be merged: expecting exactly one kind/ label Available
|
|
The following is the coverage report on the affected files.
|
jlpettersson
force-pushed
the
propagate_nodeselector_and_tolerations_to_affinity-assistant
branch
from
105c362 to
b5f67da
Compare
|
The following is the coverage report on the affected files.
|
jlpettersson
force-pushed
the
propagate_nodeselector_and_tolerations_to_affinity-assistant
branch
from
b5f67da to
8e028f9
Compare
|
The following is the coverage report on the affected files.
|
jlpettersson
force-pushed
the
propagate_nodeselector_and_tolerations_to_affinity-assistant
branch
from
8e028f9 to
090e463
Compare
|
The following is the coverage report on the affected files.
|
| will be scheduled to the same Node as the Affinity Assistant pod. This means that Affinity Assistant is incompatible | ||
| with e.g. NodeSelectors or other affinity rules configured for the `TaskRun` pods. The Affinity Assistant | ||
| with e.g. other affinity rules configured for the `TaskRun` pods. If the `PipepineRun` has a custom | ||
| [PodTemplate](pipelineruns.md#specifying-a-pod-template) configured, the `NodeSelector` and `Tolerations` fields |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bobcatfish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
To be able to run Tekton workload on a subset of the Nodes in a cluster, a NodeSelector or Tolerations can be set on the pods, e.g. by specifying a custom PodTemplate. When using the Affinity Assistant, this was not supported to customize. This commit, also propagate NodeSelector and Tolerations to the Affinity Assistant pod, so that Tekton workload can be kept to a subset of the Nodes in a cluster, also when using the Affinity Assistant. Fixes tektoncd#2742 /kind feature
jlpettersson
force-pushed
the
propagate_nodeselector_and_tolerations_to_affinity-assistant
branch
from
090e463 to
ea82f73
Compare
|
The following is the coverage report on the affected files.
|
| t.Errorf("unexpected NodeSelector in the StatefulSet") | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
🎉 thanks for redoing these twice 🙏
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-tekton-pipeline-integration-tests |
Changes
To be able to run Tekton workload on a subset of the Nodes in a cluster,
a NodeSelector or Tolerations can be set on the pods, e.g. by specifying a
custom PodTemplate.
When using the Affinity Assistant, this was not supported to customize.
This commit, also propagate NodeSelector and Tolerations to the Affinity Assistant pod,
so that Tekton workload can be kept to a subset of the Nodes in a cluster, also when
using the Affinity Assistant.
My original idea #2630 (comment) was that it could be useful to specify a specific PodTemplate for the AffinityAssistant.
But I think it is better to inherit some values from the already specified custom PodTemplate.
Fixes #2742
Fixes #2679
/kind feature
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.