Enhance v1beta1 validation code for clustertask 🍸 #3268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
requested review from
bobcatfish,
imjasonh,
pritidesai,
savitaashture and
a user
tekton-robot
added
release-note
|
/lgtm |
vdemeester
changed the title
This make a better use of knative.dev/pkg apis errors package in order to make the code simpler, *and* the report better. - This allows reporting multiple validation error at once — so, one failure message (webhook error) would be more useful to the user. - This reduce `if err != nil` path, simplifying the code. This commit tackles `ClusterTask` 🙃 Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
enhance-clustertask-validation
branch
from
941a696 to
3eeebc6
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This make a better use of knative.dev/pkg apis errors package in order
to make the code simpler, and the report better.
failure message (webhook error) would be more useful to the user.
if err != nilpath, simplifying the code.This commit tackles
ClusterTask🙃Follows-up #3185
Signed-off-by: Vincent Demeester [email protected]
/cc @sbwsg @pritidesai @bobcatfish @imjasonh @savitaashture
/kind cleanup
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes