fix(sonar): run on ubuntu and the lowest Go version #3037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdelapenya
added a commit
that referenced
this pull request
Mar 17, 2025
…er-28.0.1incompatible * main: chore!: export DockerCompose type in compose package (#2953) chore(deps): bump golang.org/x/net from 0.33.0 to 0.36.0 in /modules (#3033) chore(sonar): set main as default branch (#3038) fix(sonar): run on ubuntu and the lowest Go version (#3037) fix(ci): update core path in sonar build (#3036) fix: use empty dir for the core (#3035) fix: pass secret to the reusable workflow (#3034) chore(ci): use new GH action for SonarQube (#3007)
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Mar 17, 2025
* main: chore(deps)!: bump github.com/docker/docker from 27.1.1+incompatible to 28.0.1+incompatible (testcontainers#3017) chore!: export DockerCompose type in compose package (testcontainers#2953) chore(deps): bump golang.org/x/net from 0.33.0 to 0.36.0 in /modules (testcontainers#3033) chore(sonar): set main as default branch (testcontainers#3038) fix(sonar): run on ubuntu and the lowest Go version (testcontainers#3037) fix(ci): update core path in sonar build (testcontainers#3036) fix: use empty dir for the core (testcontainers#3035) fix: pass secret to the reusable workflow (testcontainers#3034) chore(ci): use new GH action for SonarQube (testcontainers#3007)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It skips running the sonar stages on runners that are not ubuntu-latest, and using a Go version that is not the lowest in the matrix.
Why is it important?
Update sonar just once.