Add ability to set command flags to Gcloud emulators #926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
packages/modules/gcloud/src/firestore-emulator-container.test.ts
Outdated
Show resolved
Hide resolved
cristianrgreco
added
enhancement
cristianrgreco
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #915
Added EmulatorFlagsManager class which encapsulates logic of adding arbitrary flags to command used to start gcloud containers:
Instead of hard-coding flags inside container cmd string, users can now add any flags they wish. Existing flags were preserved, existing 3rd party code should be working without changes.
Added tests for EmulatorFlagsManager.